[U-Boot] [PATCH v3 3/3] fastboot: ARM: OMAP5: Enable reboot-bootloader

[Dileep Katta]

On 27/03/2015, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Mar 25, 2015 at 04:04:52AM +0530, Dileep Katta wrote:
>
>> Implemented fb_set_reboot_flag() for OMAP5 to set
>> an environment variable 'dofastboot' when reboot-bootloader called.
>>
>> This environment variable will be checked in boot command and fastboot
>> will be called if the variable is set.
>> If the bootcmd env variable of OMAP5 common is overwritten with
>> board-specific
>> command, then these changes will not apply.
> [snip]
>> +	printf("Setting reboot to fastboot flag ...\n");
>> +	setenv("dofastboot", "1");
>> +	saveenv();
>> +	udelay(60);
> [snip]
>>  #define CONFIG_BOOTCOMMAND \
>> +	"if test ${dofastboot} -eq 1; then " \
>> +		"echo Boot fastboot requested, resetting dofastboot ...;" \
>> +		"setenv dofastboot 0; saveenv; sleep 1;" \
>> +		"echo Booting into fastboot ...; fastboot;" \
>
> No.  When saveenv returns environment is saved.  If it doesn't there's a
> bug that must be addressed.
sleep/udelay not required. Will remove and send an updated patch.
>
> --
> Tom
>
Thanks for the comment.
Regards, Dileep