[U-Boot] [PATCH] arm: implement find_next_zero_bit function

Albert ARIBAUD albert.u.boot at aribaud.net
Fri Mar 27 20:40:09 CET 2015


Hello Vitaly,

On Fri, 27 Mar 2015 15:06:15 -0400, Vitaly Andrianov <vitalya at ti.com>
wrote:
> Hello Albert,
> 
> On 03/27/2015 11:54 AM, Albert ARIBAUD wrote:
> > Hello Vitaly,
> >
> > On Wed, 11 Feb 2015 14:11:12 -0500, Vitaly Andrianov <vitalya at ti.com>
> > wrote:
> >>
> >>
> >> On 02/05/2015 12:52 PM, Albert ARIBAUD wrote:
> >>> Hello Vitaly,
> >>>
> >>> On Thu, 5 Feb 2015 11:24:46 -0500, Vitaly Andrianov <vitalya at ti.com>
> >>> wrote:
> >>>> This commit copies implementation of the find_next_zero_bit() from
> >>>> git://git.denx.de/u-boot.git/arch/mips/include/asm/bitops.h. v2014.07
> >>>>
> >>>> The function is required to enable MCAST_TFTP support for ARM platforms.
> >>>
> >>> Which mainline board needs this?
> >>
> >> TI Keystone2 EVMs
> >
> > Just to make sure: this is actually replacing a 'normal' function with
> > an inline one. So the function /was/ available before this patch,
> > right?
> >
> What inline function are you talking about?

The one you are adding with this patch.

> I couldn't find this function for ARM. That is why I copied it from MIPS.

Thanks -- I had noticed that you were removing extern declarations for
find_first_zero_bit() and find_next_zero_bit() and I was surprised
that this removal was not explained in the commit message, and I had
not realized that the corresponding function definitions did not exist.

I'll apply your patch and add a note in the commit message explaining
the removal.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list