[U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

Paul Kocialkowski contact at paulk.fr
Mon Mar 30 15:28:49 CEST 2015


Le lundi 30 mars 2015 à 10:06 +0200, Lukasz Majewski a écrit :
> Hi Paul,
> 
> > Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
> > ---
> >  common/cmd_fastboot.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > index 346ab80..7956a5b 100644
> > --- a/common/cmd_fastboot.c
> > +++ b/common/cmd_fastboot.c
> > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
> > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
> > { puts("\rUSB cable not detected.\n" \
> >  		     "Command exit.\n");
> > +		g_dnl_unregister();
> > +		g_dnl_clear_detach();
> >  		return CMD_RET_FAILURE;
> >  	}
> >  
> 
> This is just a minor comment - in your future patches please add some
> commit message even for this very short patch.

Understood.

> Despite that, 
> 
> Acked-by: Lukasz Majewski <l.majewski at samsung.com>
> 
> If other (Marek, Tom) don't mind I will take this through -dfu tree.

Thanks!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150330/ca574223/attachment.sig>


More information about the U-Boot mailing list