[U-Boot] [PATCH V2 2/3] Kconfig: i2c: fix help message related to dm i2c

[Przemyslaw Marczak]

Hello Simon,

On 03/28/2015 04:08 PM, Simon Glass wrote:
> Hi Przemyslaw,
>
> On 27 March 2015 at 11:33, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>> Cc: Mike Frysinger <vapier at gentoo.org>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Heiko Schocher <hs at denx.de>
>>
>> Changes V2:
>> - add i2c uclass description
>> ---
>>   drivers/i2c/Kconfig | 17 +++++++----------
>>   1 file changed, 7 insertions(+), 10 deletions(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> (see nit below)
>
>>
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index 692810d..979522f 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -2,16 +2,13 @@ config DM_I2C
>>          bool "Enable Driver Model for I2C drivers"
>>          depends on DM
>>          help
>> -         Enable driver model for I2C. This SPI flash interface
>> -         (spi_flash_probe(), spi_flash_write(), etc.) is then
>> -         implemented by the SPI flash uclass. There is one standard
>> -         SPI flash driver which knows how to probe most chips
>> -         supported by U-Boot. The uclass interface is defined in
>> -         include/spi_flash.h, but is currently fully compatible
>> -         with the old interface to avoid confusion and duplication
>> -         during the transition parent. SPI and SPI flash must be
>> -         enabled together (it is not possible to use driver model
>> -         for one and not the other).
>> +         Enable driver model for I2C. The I2C uclass interface: probe, read,
>> +         write or speed, is implemented with the bus drivers uclass operations,
>> +         which provides methods for bus setting and data transfer. Each chip
>
> Can we tweak this a bit?
>
>           write and speed, is implemented with the bus drivers' operations,
>           which provide methods for bus setting and data transfer. Each chip
>
>

Ok, will corrent this.

>> +         device (bus child) info is kept as parent platdata. The interface is
>> +         defined in include/i2c.h. When i2c bus driver supports the i2c uclass,
>> +         but the device drivers not, then DM_I2C_COMPAT config can be used as
>> +         compatibility layer.
>>
>>   config DM_I2C_COMPAT
>>          bool "Enable I2C compatibility layer"
>> --
>> 1.9.1
>>
>
> Regards,
> Simon
>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com