[U-Boot] [U-Boot, 02/10] arm: s3c24xx: Fix incorrect CONFIG_SYS_S3C2410_NAND_HWECC name

Marek Vasut marex at denx.de
Sat May 2 02:46:05 CEST 2015


On Thursday, November 27, 2014 at 03:03:50 AM, Scott Wood wrote:
> On Sat, Oct 11, 2014 at 06:42:50PM +0200, Marek Vasut wrote:
> > The correct name of this symbol is CONFIG_S3C2410_NAND_HWECC , the
> > _SYS is redundant.
> 
> What makes that the correct name?  The symbol is not documented anywhere,
> and while nothing currently tests for the SYS version, nothing currently
> sets the non-SYS version.
> 
> What is SYS redundant with?
> 
> Is this meant to be a user config knob or something that is fixed for a
> given board?

u-boot$ git grep CONFIG_SYS_S3C2410_NAND_HWECC
include/configs/VCMA9.h:#define CONFIG_SYS_S3C2410_NAND_HWECC
include/configs/smdk2410.h:#define CONFIG_SYS_S3C2410_NAND_HWECC

u-boot$ git grep CONFIG_S3C2410_NAND_HWECC
drivers/mtd/nand/s3c2410_nand.c:#ifdef CONFIG_S3C2410_NAND_HWECC
drivers/mtd/nand/s3c2410_nand.c:#ifdef CONFIG_S3C2410_NAND_HWECC

The driver checks the version without _SYS. This is a clear bugfix,
so please apply.

Best regards,
Marek Vasut


More information about the U-Boot mailing list