[U-Boot] [PATCH v2 08/10] sunxi: Add basic A33 basic support

[Ian Campbell]

On Sun, 2015-04-26 at 20:52 +0200, Hans de Goede wrote:
> From: Vishnu Patekar <vishnupatekar0510 at gmail.com>
> 
> Enable full support for the A33 SoC including display, otg-usb, etc.
> 
> Signed-off-by: Vishnu Patekar <vishnupatekar0510 at gmail.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Acked-by: Ian Campbell <ijc at hellion.org.uk>

> -#if defined(CONFIG_MACH_SUN8I_A23)
> +#if defined(CONFIG_MACH_SUN8I_A23) || defined(CONFIG_MACH_SUN8I_A33)

There's a lot of these A23||A33 (and !A23&&!A33). Perhaps a hidden
MACH_SUN8I_COMMON selected by both would be helpful?

With or without the _COMMON suffix as you prefer, although without would
remove 90% of the changes in this patch.

Can defer it until later if you prefer, or you may retain my ack if you
want to make the change in the obvious way.

Ian.