[U-Boot] [PATCH v3 0/1] dm: usb: Copy over usb_device values from usb_scan_device() to final usb_device

Simon Glass sjg at chromium.org
Mon May 4 19:22:45 CEST 2015


Hi Hans,

On 4 May 2015 at 11:19, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi Simon,
>
> Here is v3 of my patch to fix the maxpacketsize0 not being set issue I
> found and related issues.
>
> I've added a big fat comment to explain that the usb_device pointer is a
> hack and should not be used outside of usb-uclass.c as requested.
>
> I hope this version is to your liking and you can ack it.
>
> Assuming that you do ack it, then my entire dm-usb fixes + ehci set is
> all acked, and the question becomes how to take uit upstream, I can take
> the entire set upstream through the sunxi tree, or you can take it
> upstream through the dm tree. Let me know which way you prefer to move
> forward with this.

I should probably take it through DM. I'll do a pull request once the
x86 pull request goes in.

But I'm still not sure how it is safe to pass a pointer to a local
stack variable out through another function. Can you please explain
that?

Regards,
Simon


More information about the U-Boot mailing list