[U-Boot] [PATCH v3 00/26] Improve env var handling for net stack

Joe Hershberger joe.hershberger at gmail.com
Mon May 4 20:34:24 CEST 2015


Hi Tom,

On Sun, May 3, 2015 at 3:12 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> This includes moving CONFIG_REGEX to Kconfig and adding support for
> regex to the env_attr lists (when CONFIG_REGEX is enabled).
>
> This allows ethaddrs to all be checked for access and format by default.
> Also use callbacks to keep network stack variables up to date instead of
> polling them on each call to net_loop.
>
> This is a step in the right direction to refactoring the network stack
> to be similar to that of barebox.
>
> Also added a test command to host unit tests for the env functions.
>
> Changes in v3:
> -Moved test from env subcommand to ut subcommand
> -New for version 3
>
> Changes in v2:
> -Added comments about the use of .flags in the dm eth test
> -Added description to README
> -Fix bisectability issue
> -Fix corner case in reverse_name_search() where searched starts with ' '
> -New for version 2
> -Simplified test for H_PROGRAMMATIC
>
> Joe Hershberger (26):
>   sandbox: Enable some ENV commands
>   kconfig: Move REGEX to Kconfig
>   sandbox: Enable regex support
>   env: Fix return values in env_attr_lookup()
>   env: Simplify the reverse_strstr() interface
>   env: Allow env_attr_walk to pass a priv * to callback
>   env: Add regex support to env_attrs
>   env: Distinguish finer between source of env change
>   net: Apply default format rules to all ethaddr
>   net: Use env callbacks for net variables
>   net: Add default flags for common net env vars
>   net: Remove duplicate bootfile syncing functionality
>   net: Handle ethaddr changes as an env callback
>   test: Generalize the unit test framework
>   test: Add a common unit test command
>   test: Move the unit tests to their own menu
>   test: dm: Don't bail on all tests if one test fails
>   test: dm: eth: Handle failed test env cleanup
>   test: Return values from the asserts compatible with cmds
>   test: dm: Recover the driver model tree after tests
>   test: env: Add test framework for env
>   test: env: Add test for verifying env attrs
>   test: env: Add a test of the new regex behavior for attrs
>   test: dm: Move the dm tests over to the ut command
>   sandbox: Cleanup order and extra defines in defconfig
>   sandbox: Enable env unit tests

Would you prefer this to go through u-boot/net or would you prefer to
pull it in directly? It has a fair amount of env and test changes.

Speaking of, are you the maintainer of the "env" area of the code?
Wolfgang used to comment on it primarily, so I don't know if that role
went to you along with mainline.

Please let me know... Thanks,
-Joe


More information about the U-Boot mailing list