[U-Boot] [PATCH 3/3] net: Remove all calls to net_random_ethaddr()

Michael Walle michael at walle.cc
Wed May 6 11:10:17 CEST 2015


Hi Joe,

Am 2015-05-05 19:36, schrieb Joe Hershberger:
>> You removed the "set_led(LED_ALARM_BLINKING)". (Mh, I've just 
>> discovered,
>> that there is an indentation error). This is very important for this 
>> board,
>> because there is no other feedback to the user than the LED. Remember, 
>> there
>> is no serial console by default for this board. Please provide some 
>> kind of
>> callback where you can move the sed_led() call to.
> 
> The reason I removed it is because the only condition that was being
> checked for failure no longer happens at all. It only checked that the
> address could be written to the env. The policy is that the random
> address is not written to the env, but simply used for that boot. As
> such, there is nothing to fail.

Oh, sorry.

Yes this can then be removed. The check I had in mind was the one in 
check_enetaddr(). But i guess this will still work with the changes.

Again, sorry for the noise :(

Acked-By: Michael Walle <michael at walle.cc> (for the lsxl board part)

-michael



More information about the U-Boot mailing list