[U-Boot] [PATCH 1/2] Fix inconsistency of VERIFY defines in cmd_mem

Simon Glass sjg at chromium.org
Wed May 6 16:50:13 CEST 2015


Hi Joe,

On 5 May 2015 at 17:35, Joe Hershberger <joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Tue, May 5, 2015 at 4:37 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Joe,
>>
>> On 5 May 2015 at 11:23, Joe Hershberger <joe.hershberger at ni.com> wrote:
>>>
>>> Introduced in change d20a40de9db07de1f1f06a79a4da1cdda5379b75
>>> "Roll crc32 into hash infrastructure"
>>>
>>> Use a consistent define to enable the verify feature in crc32 command.
>>>
>>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>>> ---
>>>
>>>  common/cmd_mem.c | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
>>> index 5d8c9e6..b91adb2 100644
>>> --- a/common/cmd_mem.c
>>> +++ b/common/cmd_mem.c
>>> @@ -1303,7 +1303,7 @@ U_BOOT_CMD(
>>>
>>>  #ifdef CONFIG_CMD_CRC32
>>>
>>> -#ifndef CONFIG_CRC32_VERIFY
>>> +#ifndef CONFIG_HASH_VERIFY
>>
>> Do you need to change the users of CONFIG_CRC32_VERIFY?
>
> Shouldn't need to just like you didn't on the other similar change to
> this file because in include/hash.h:
>
> #if defined(CONFIG_SHA1SUM_VERIFY) || defined(CONFIG_CRC32_VERIFY)
> #define CONFIG_HASH_VERIFY
> #endif

OK, thanks.

Acked-by: Simon Glass <sjg at chromium.org>
[snip]

Regards,
Simon


More information about the U-Boot mailing list