[U-Boot] [RFC PATCH v1] Makefile: Add U_BOOT_TZ and include in version

[Simon Glass]

Hi Chris,

On 5 May 2015 at 23:38, Chris Packham <judge.packham at gmail.com> wrote:
> Hi,
>
> On Thu, Apr 30, 2015 at 12:38 PM, Chris Packham <judge.packham at gmail.com> wrote:
>> Define U_BOOT_TZ alongside U_BOOT_TIME and U_BOOT_DATE and use it to
>> include the timezone in the version output.
>>
>> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>> ---
>>
>>  Makefile          | 3 ++-
>>  include/version.h | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 1e52008..c6b8d3f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1230,7 +1230,8 @@ endef
>>
>>  define filechk_timestamp.h
>>         (LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"'; \
>> -       LC_ALL=C date +'#define U_BOOT_TIME "%T"')
>> +       LC_ALL=C date +'#define U_BOOT_TIME "%T"'; \
>> +       LC_ALL=C date +'#define U_BOOT_TZ "%Z"')
>>  endef
>>
>>  $(version_h): include/config/uboot.release FORCE
>> diff --git a/include/version.h b/include/version.h
>> index d6c7cf2..777e9f6 100644
>> --- a/include/version.h
>> +++ b/include/version.h
>> @@ -19,7 +19,7 @@
>>  #endif
>>
>>  #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
>> -       U_BOOT_TIME ")" CONFIG_IDENT_STRING
>> +       U_BOOT_TIME " " U_BOOT_TZ ")" CONFIG_IDENT_STRING
>>
>>  #ifndef __ASSEMBLY__
>>  extern const char version_string[];
>> --
>> 2.3.5
>>
>
> Any feedback? I see I've now missed the merge window (sending the
> patch as RFC on the day before it closed didn't help, sorry about
> that). But is the general idea OK for when I re-submit when the next
> merge window opens?

Seems like a reasonable idea to me.

Acked-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>

Regards,
Simon