[U-Boot] [PATCH] mtd: sf: Add CONFIG_SPI_N25Q256A_RESET for software-reset

[Marek Vasut]

On Sunday, May 10, 2015 at 11:07:38 AM, Pavel Machek wrote:
> On Fri 2015-05-01 19:26:34, Marek Vasut wrote:
> > On Friday, May 01, 2015 at 04:49:37 PM, Pavel Machek wrote:
> > > On Fri 2015-05-01 16:24:45, Marek Vasut wrote:
> > > > On Friday, May 01, 2015 at 11:01:09 AM, Pavel Machek wrote:
> > > > > diff --git a/drivers/mtd/spi/sf_probe.c
> > > > > b/drivers/mtd/spi/sf_probe.c index 201471c..f7cfbd9 100644
> > > > > --- a/drivers/mtd/spi/sf_probe.c
> > > > > +++ b/drivers/mtd/spi/sf_probe.c
> > > > > @@ -347,6 +348,36 @@ int spi_flash_probe_slave(struct spi_slave
> > > > > *spi, struct spi_flash *flash) }
> > > > > 
> > > > >  	}
> > > > > 
> > > > > +#ifdef CONFIG_SPI_N25Q256A_RESET
> > > > 
> > > > Should be CONFIG_SPI_MICRON_RESET, since other parts which can also
> > > > be used would have similar issue.
> > > 
> > > I'm pretty sure some Micron parts use different interface.
> > 
> > Which ones ?
> 
> N25Q128?

According to [1] page 28,  the interface is the same. Did I miss something?

[1] https://www.micron.com/~/media/documents/products/data-sheet/nor-
flash/serial-nor/n25q/n25q_128_3_volt_with_boot_sector.pdf

> > > > It'd be nice if you
> > > > added diffstat into your patches as it makes things easier during
> > > > review.
> > > 
> > > Yes, it also makes patch harder to create (as it is tricky to
> > > hand-edit the patches)
> > 
> > git format-patch automatically inserts the diffstat for you.
> 
> As I have already told you, I'm not using git to submit my patches.

Please fix your tools then.

[...]

Best regards,
Marek Vasut