[U-Boot] [PATCH v5 12/15] usb: ohci: Skip unnecessary mdelay(1) calls in various places

Marek Vasut marex at denx.de
Sun May 10 18:12:07 CEST 2015


On Sunday, May 10, 2015 at 02:10:24 PM, Hans de Goede wrote:
> For some reason the ohci code is full with:
> 
>  #ifdef DEBUG
> 		pkt_print(...)
>  #else
> 		mdelay(1);
>  #endif
> 
> AFAICT there is no reason for the mdelay(1) calls. This commit disables
> them when building the ohci code for new driver-model using boards. It
> leaves the mdelay(1) calls in place when building for older boards, so as
> to avoid causing any regressions there.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Maybe those debug prints can be abstracted into one single function instead
of having the code littered with #ifdef-else-endif , but let's do that later
or in another patch.

Acked-by: Marek Vasut <marex at denx.de>
[...]
Best regards,
Marek Vasut


More information about the U-Boot mailing list