[U-Boot] [PATCH 02/10] imx6: move all standard includes to mx6_common.h

Peter Robinson pbrobinson at gmail.com
Mon May 11 15:13:00 CEST 2015


On Mon, May 11, 2015 at 1:32 PM, Tom Rini <trini at konsulko.com> wrote:
> On Mon, May 11, 2015 at 12:23:21PM +0100, Peter Robinson wrote:
>
>> The linux/sizes.h, asm/arch/imx-regs.h, asm/imx-common/gpio.h,
>> config_cmd_default.h includes are used fairly universally across imx6 boards
>> so include them in mx6_common.h by default.
> [snip]
>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
>> index e0528ce..edaa4f6 100644
>> --- a/include/configs/mx6_common.h
>> +++ b/include/configs/mx6_common.h
>> @@ -31,4 +31,9 @@
>>  #define CONFIG_MP
>>  #define CONFIG_MXC_GPT_HCLK
>>
>> +#include <linux/sizes.h>
>> +#include <asm/arch/imx-regs.h>
>> +#include <asm/imx-common/gpio.h>
>> +#include <config_cmd_default.h>
>
> This and then 7/10 aren't quite right.  We want to make sure that prior
> to including config_cmd_default.h we set CONFIG_SYS_NO_FLASH so that we
> don't have to undef CONFIG_CMD_FLASH / CONFIG_CMD_IMLS

OK, so is it enough to reorder them in the mx6_common.h?

Peter


More information about the U-Boot mailing list