[U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define to mx6_common.h

[Tom Rini]

On Mon, May 11, 2015 at 01:51:04PM +0100, Peter Robinson wrote:
> On Mon, May 11, 2015 at 1:43 PM, Tom Rini <trini at konsulko.com> wrote:
> > On Mon, May 11, 2015 at 12:23:24PM +0100, Peter Robinson wrote:
> >
> >> Define CONFIG_MXC_GPIO by default in mx6_common
> >>
> >> Signed-off-by: Peter Robinson <pbrobinson at gmail.com>
> > [snip]
> >> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
> >> index b30ffb2..e54eee2 100644
> >> --- a/include/configs/mx6_common.h
> >> +++ b/include/configs/mx6_common.h
> >> @@ -47,4 +47,7 @@
> >>  #define CONFIG_INITRD_TAG
> >>  #define CONFIG_REVISION_TAG
> >>
> >> +/* GPIO */
> >> +#define CONFIG_MXC_GPIO
> >> +
> >>  #endif
> > [snip]
> >> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> >> index f1fd599..0142791 100644
> >> --- a/include/configs/nitrogen6x.h
> >> +++ b/include/configs/nitrogen6x.h
> >> @@ -19,8 +19,6 @@
> >>
> >>  #define CONFIG_BOARD_EARLY_INIT_F
> >>  #define CONFIG_MISC_INIT_R
> >> -#define CONFIG_MXC_GPIO
> >> -#define CONFIG_CMD_GPIO
> >>  #define CONFIG_CI_UDC
> >>  #define CONFIG_USBD_HS
> >>  #define CONFIG_USB_GADGET_DUALSPEED
> > [snip]
> >> diff --git a/include/configs/platinum.h b/include/configs/platinum.h
> >> index 2d18098..45a74b0 100644
> >> --- a/include/configs/platinum.h
> >> +++ b/include/configs/platinum.h
> >> @@ -26,7 +26,6 @@
> >>  #define CONFIG_CMD_EXT2
> >>  #define CONFIG_CMD_FAT
> >>  #define CONFIG_CMD_FUSE
> >> -#define CONFIG_CMD_GPIO
> >>  #define CONFIG_CMD_I2C
> >>  #undef  CONFIG_CMD_IMLS
> >>  #define CONFIG_CMD_MII
> >
> > You're dropping CONFIG_CMD_GPIO (a handy thing IMHO) in a few cases and
> > not adding it in globally which I would argue is the right thing to do.
> 
> Bah, oversight! OK to add it back to mx6_common.h in a follow up patch?

I think fixing up 2/10 (and re-ordering for bisectability after doing
that) is going to mean you need to re-post the whole series anyhow.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150511/cd253e33/attachment.sig>