[U-Boot] [PATCH 3/4] imx: mx6: add display of temperature grade of processor in cpu_printinfo()

Tim Harvey tharvey at gateworks.com
Mon May 11 21:59:42 CEST 2015


On Sun, May 10, 2015 at 7:54 AM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Tim,
>
> On Tue, Apr 28, 2015 at 12:44 PM, Tim Harvey <tharvey at gateworks.com> wrote:
>
>> +#if defined(CONFIG_IMX6_THERMAL)
>> +               switch (get_cpu_temp_grade(&minc, &maxc)) {
>> +               case TEMP_AUTOMOTIVE:
>> +                       puts(" automotive");
>> +                       break;
>> +               case TEMP_INDUSTRIAL:
>> +                       puts(" industrial");
>> +                       break;
>> +               case TEMP_EXTCOMMERCIAL:
>> +                       puts(" extended commercial");
>> +                       break;
>> +               default:
>> +                       puts(" commercial");
>
> Could you please change 'commercial' to 'consumer'?
>
> That's the term we see in the datasheet.
>
> I also agree with Nikolay that it would be better to split the CPU
> line info in two now.
>
> Thanks,
>
> Fabio Estevam

Fabio,

It looks like I convinced you in the thread regarding the similar
patch to the kernel
(http://www.spinics.net/lists/arm-kernel/msg417378.html) that the
verbiage should remain as is, but I will follow-up with a v2 that puts
the thermal information on the line with the current temperature.

Tim


More information about the U-Boot mailing list