[U-Boot] [PATCH] Clean all defconfigs with savedefconfig

Joe Hershberger joe.hershberger at gmail.com
Mon May 11 22:17:15 CEST 2015


Hi Stephen,

On Mon, May 11, 2015 at 3:02 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 05/11/2015 11:08 AM, Joe Hershberger wrote:
>>
>> In order to reduce merge conflicts and to maintain the simplest possible
>> defconfig files, we should be using the savedefconfig feature of Kconfig
>> every time a new feature is added. This keeps the defconfig settings to
>> a minimum (only those things not default) and keeps them in the same
>> order as the Kconfig options.
>
>
>> diff --git a/configs/jetson-tk1_defconfig b/configs/jetson-tk1_defconfig
>
>
>> -CONFIG_TARGET_JETSON_TK1=y
>
>
> Doesn't that (and the equivalent change in other files such as
> harmony_defconfig) break the build, since the Kconfig option that selects
> the particular board is no longer selected?

That's a bit of a peculiar case caused by the fact that Kconfig sees
that board as the default board, so it removes the explicit setting.

The only problem I see with that is if a new board is added to the top
of the list. We can maybe fix this by changing all of the menus of
boards to optional, but I'm not sure that's what we want either.

Thoughts?
-Joe


More information about the U-Boot mailing list