[U-Boot] [PATCH] sandbox: Tidy up terminal restore

Simon Glass sjg at chromium.org
Tue May 12 00:40:55 CEST 2015


Hi Joe,

On 11 May 2015 at 14:00, Joe Hershberger <joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Sun, May 10, 2015 at 10:07 PM, Simon Glass <sjg at chromium.org> wrote:
>> For some reason 'u-boot -D' does not restore the terminal correctly when
>> the 'reset' command is used. Call the terminal restore function explicitly
>> in this case.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>
> This is probably what breaks my terminal most times a test fails by
> crashing. I guess this still won't address that. Why do we need to
> mess with the terminal?

To put it into 'raw' mode so that we can use our normal tstc() /
getc() functions and don't need to wait for an end-of-line.

>
> Reviewed-by: Joe Hershberger <joe.hershberger at ni.com>

Regards,
Simon


More information about the U-Boot mailing list