[U-Boot] [PATCH v5 15/15] sunxi: ohci: Add ohci usb host controller support

[Hans de Goede]

Hi,

On 13-05-15 00:39, Simon Glass wrote:
> Hi Hans,
>
> On 12 May 2015 at 01:23, Hans de Goede <hdegoede at redhat.com> wrote:
>>
>> Hi Simon,
>>
>>
>> On 12-05-15 00:37, Simon Glass wrote:
>>>
>>> On 10 May 2015 at 06:10, Hans de Goede <hdegoede at redhat.com> wrote:
>>>>
>>>> This commit adds support for the OHCI companion controller, which makes
>>>> usb-1 devices directly plugged into to usb root port work.
>>>>
>>>> Note for now this switches usb-keyboard support for sunxi back from int-queue
>>>> support to the old interrupt polling method. Adding int-queue support to the
>>>> ohci code and switching back to int-queue support is in the works.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>>> Acked-by: Marek Vasut <marex at denx.de>
>>>> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>>>> ---
>>>>    arch/arm/include/asm/arch-sunxi/clock_sun4i.h |   2 +
>>>>    arch/arm/include/asm/arch-sunxi/clock_sun6i.h |   2 +
>>>>    drivers/usb/host/Makefile                     |   1 +
>>>>    drivers/usb/host/ohci-sunxi.c                 | 104 ++++++++++++++++++++++++++
>>>>    include/configs/sunxi-common.h                |   5 +-
>>>>    5 files changed, 113 insertions(+), 1 deletion(-)
>>>>    create mode 100644 drivers/usb/host/ohci-sunxi.c
>>>
>>>
>>> Applied to u-boot-dm, thanks!
>>
>>
>> Thanks for merging this series!
>>
>> Can you pick up these patches from yesterday too ? They have already
>> been reviewed and acked by Marek, and they sit on to of
>> this series :
>>
>> http://patchwork.ozlabs.org/patch/471001/
>> http://patchwork.ozlabs.org/patch/471004/
>> http://patchwork.ozlabs.org/patch/471003/
>> http://patchwork.ozlabs.org/patch/471005/
>>
>> Note the last one has queue misspelled (twice) in the commit
>> msg you may want to amend that.
>
> I get a build error with M5485BFE. I stopped the build after that so
> there may be others.
>
> 21: sunxi: Change usb-kbd interrupt polling to use an usb interrupt queue
>        m68k:  +   M5485BFE
> -make[2]: *** [drivers/usb/musb-new/musb_host.o] Interrupt
> -make[1]: *** [drivers/usb/musb-new] Interrupt
> -make: *** wait: No child processes.  Stop.
> -make[2]: *** Deleting file `drivers/mmc/mmc.o'
> -make[2]: *** [drivers/mmc/mmc.o] Interrupt
> -make[1]: *** [drivers/mmc] Interrupt
> +../drivers/usb/host/ohci-hcd.c:1637:46: error: 'struct usb_device'
> has no member named 'dev'
> +../drivers/usb/host/ohci-hcd.c: In function '_ohci_poll_int_queue':
> +../drivers/usb/host/ohci-hcd.c:1683:46: error: 'struct usb_device'
> has no member named 'dev'
> +make[2]: *** [drivers/usb/host/ohci-hcd.o] Error 1
> +make[1]: *** [drivers/usb/host] Error 2
> +make: *** [sub-make] Error 2
> w+../drivers/usb/host/ohci-hcd.c: In function '_ohci_create_int_queue':
> w+../drivers/usb/host/ohci-hcd.c:1637:2: warning: implicit declaration
> of function 'usb_get_bus' [-Wimplicit-function-declaration]
>
> Actually, it found these also:
>
>         arm:  +   pm9g45 at91sam9g20ek_2mmc_nandflash
>        m68k:  +   M5485BFE
>     powerpc:  +   PLU405 MPC8641HPCN_36BIT digsy_mtc_rev5 PMC440 yosemite
>
> Am I missing a patch perhaps?

No, this is my bad, I did not test building with any configs which have
CONFIG_DM_USB=n

A v2 of this set with this fixed is coming up.

Regards,

Hans