[U-Boot] [PATCH V5 2/2] imx: mx27 move GPIO_PORTx to gpio.h

Simon Glass sjg at chromium.org
Fri May 15 15:53:21 CEST 2015


On 14 May 2015 at 17:29, Peng Fan <Peng.Fan at freescale.com> wrote:
> These GPIO_PORTx macros should be in gpio.h, but not in imx-regs.h.
>
> Also, imx-regs.h and iomux-v3.h has same macro defintion for
> GPIO_PORTx, and both of them are included in mxc_i2c.c(include
> mxc_i2c.h). This will incur build warnings with macro redefinition.
>
> Since iomux-v3.h is not compatible with mx27, we can not simply
> include iomux-v3.h for mx27, so move the GPIO_PORTx to gpio.h to
> fix the build warning.
>
> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
> ---
>
> Changes v5:
>  Take Fabio's suggestion.
>  Since iomux-v3.h is not compatible with mx27, we can not directly
>  include iomux-v3.h for mx27. Move the GPIO_PORTx to gpio.h which
>  should be not in imx-regs.h.
>
> Changes v4:
>  New patch.
>  we include mxc_i2c.h in driver/i2c/mxc_i2c.c in patch 1/2.
>  mxc_i2c.h includes iomux-v3.h.
>  Since iomux-v3.h have some macros which also exists in
>  asm/arch-xx/imx-regs.h, this will introudce compile warnings
>  such as "redefined macro".
>
> Changes v3:
>  none
>
> Changes v2:
>  none
>
>  arch/arm/include/asm/arch-mx27/gpio.h     | 20 ++++++++++++++++++++
>  arch/arm/include/asm/arch-mx27/imx-regs.h | 22 ----------------------
>  2 files changed, 20 insertions(+), 22 deletions(-)

Applied to u-boot-dm, take 2, thanks!


More information about the U-Boot mailing list