[U-Boot] [PATCH v3 3/4] arm: ls102xa: Enable Driver Model SPI for ls1021aqds

York Sun yorksun at freescale.com
Mon May 18 18:22:43 CEST 2015


Haikun,

On 05/18/2015 06:24 AM, Haikun Wang wrote:
> Enable Driver Model SPI for ls1021aqds board.
> DSPI and QSPI is enabled only when boot from QSPI.
> DSPI and QSPI are compatible under Driver Model SPI.
> 
> Signed-off-by: Haikun Wang <Haikun.Wang at freescale.com>
> ---
> Changes in v3:
> - Remove CONFIG_SPI_FLASH_ATMEL
> - IS_ENABLED(CONFIG_XXX) is only work with configure option in Kconfig,
>   and DM core code use IS_ENABLED(), so configure option in head file
>   can't work, so remove CONFIG_OF_CONTROL CONFIG_OF_SEPARATE CONFIG_DM CONFIG_DM_SPI
> 
> Changes in v2:
> - Move all changes inside of CONFIG_QSPI_BOOT 
> 
> Changes in v1: None
>  include/configs/ls1021aqds.h | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)


I lost track of your patch set. You have v3 3/4 and v3 4/4. Where are the first
two patches in this set?

The subject arm:ls102xa is not too bad. For future patches, I prefer the subject
to be <arch>/<soc>, or <arch>/<board>. This one should have arm/ls1021aqds, or
armv7/ls1021aqds. It helps maintainers to delegate the patches to custodians.

York


More information about the U-Boot mailing list