[U-Boot] [PATCH 0/10 v2] i.MX6: move duplicated options to mx6_common to standardise mx6 config

[Stefano Babic]

Hi Peter,

On 11/05/2015 18:22, Peter Robinson wrote:
> There's a lot of common options in the i.MX6 boards that are repeated across a 
> lot of the devices. There's a mx6_common.h which is little used but makes sense
> to be the central location for all the options we want across all mx6 boards to
> ensure a consistent set of features. This is a first pass at moving those options
> and unifying the common options to a standard default.
> 
> Changes since v1:
> * Move CONFIG_SYS_NO_FLASH changes from patch 7 to patch 2 and reorder includes
> so we don't need to undef CONFIG_CMD_FLASH / CONFIG_CMD_IMLS
> * Add CONFIG_CMD_GPIO to mx6_common.f (patch 5)
> * Use the default for all CONFIG_SYS_PROMPT_HUSH_PS2 (patch 7)
> * Drop LZO change (patch 8) 
> 
> I think I got all the review points :)
> 
> Peter Robinson (10):
>       novena: standardise mx6_common.h include
>       imx6: move all standard includes to mx6_common.h
>       imx6: move generic imx6 options to mx6_common.h
>       imx6: move standard ATAG configs to mx6_common.h
>       imx6: move MXC_GPIO define to mx6_common.h
>       imx6: centralise common boot options in mx6_common.h
>       imx6: move generic miscellaneous and overwrite options
>       imx6: standardise filesystem and boot options
>       imx6: generic MMC config options to mx6_common
>       mx6: standardise CONFIG_CMD_CACHE
> 
> Reviewed-by: Eric Nelson <eric.nelson at boundarydevices.com>
> 

Applying your patchset (I had to merge something due to changes in
tree), I get several warnings due to duplicated #define.

For example, tqma6 defines CONFIG_SYS_TEXT_BASE. I agree to have it in
mx6_common, we need a #undef CONFIG_SYS_TEXT_BASE in the board
configuration file for boards (like tqma6) that redefines it.

CONFIG_BOOTDELAY is also set in config_distro_defaults, and it generates
also a warning - maybe we have to remove it from mx6_common.h

Can you check these issues and repost a V3 on current u-boot-imx tree ?

Thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================