[U-Boot] [PATCH v4 06/10] moveconfig: Remove probable debug print

Joe Hershberger joe.hershberger at gmail.com
Tue May 19 17:36:58 CEST 2015


Hi Masahiro-san,

On Mon, May 18, 2015 at 9:10 PM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Hi Joe
>
> 2015-05-16 6:40 GMT+09:00 Joe Hershberger <joe.hershberger at ni.com>:
>> This print seems to be redundant and unformatted compared to the next
>> few lines, so remove it.
>>
>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>  tools/moveconfig.py | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/moveconfig.py b/tools/moveconfig.py
>> index 25cee21..15b0f2b 100755
>> --- a/tools/moveconfig.py
>> +++ b/tools/moveconfig.py
>> @@ -725,7 +725,6 @@ class Slots:
>>          if len(failed_boards) > 0:
>>              msg = [ "The following boards were not processed due to error:" ]
>>              msg += failed_boards
>> -            print msg
>>              for line in msg:
>>                  print >> sys.stderr, color_text(self.options.color,
>>                                                  COLOR_LIGHT_RED, line)
>> --
>
> Oops, my mistake.
>
> Acked-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>
>
> (Or, because it is a simply bug fix, you can comment on my base patch.)

I'm dropping this patch and sent a reply to your original patch (not
applied to master yet).

-Joe


More information about the U-Boot mailing list