[U-Boot] [PATCH v4 09/10] moveconfig: Add a switch to enable printing errors

[Joe Hershberger]

Hi Masahiro-san,

On Mon, May 18, 2015 at 10:25 PM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> 2015-05-16 6:40 GMT+09:00 Joe Hershberger <joe.hershberger at ni.com>:
>> In some cases the build for the autoconf breaks. This outputs the errors
>> following the status so that action can be taken without building again
>> manually.
>>
>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2:
>> -New for version 2
>>
>>  tools/moveconfig.py | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/tools/moveconfig.py b/tools/moveconfig.py
>> index f986f55..685b47b 100755
>> --- a/tools/moveconfig.py
>> +++ b/tools/moveconfig.py
>> @@ -153,6 +153,9 @@ Available options
>>     Specify the number of threads to run simultaneously.  If not specified,
>>     the number of threads is the same as the number of CPU cores.
>>
>> + -v, --verbose
>> +   Show any build errors as boards are built
>> +
>>  To see the complete list of supported options, run
>>
>>    $ tools/moveconfig.py -h
>> @@ -615,6 +618,9 @@ class Slot:
>>                                           COLOR_LIGHT_RED,
>>                                           self.defconfig,
>>                                           errmsg),
>> +            if self.options.verbose:
>> +                print >> sys.stderr, color_text(self.options.color,
>> +                                                COLOR_LIGHT_CYAN, errout)
>>              if self.options.exit_on_error:
>>                  sys.exit("Exit on error.")
>>              else:
>> @@ -882,6 +888,9 @@ def main():
>>                        help='only cleanup the headers')
>>      parser.add_option('-j', '--jobs', type='int', default=cpu_count,
>>                        help='the number of jobs to run simultaneously')
>> +    parser.add_option('-v', '--verbose', dest='verbose',
>> +                      action='store_true', default=False,
>> +                      help='show any build errors as boards are built')
>
> dest='verbose' is redundant.
>
> The destination is chosen based on the long option name.

OK. Dropped.

> Apart from that, I think this is a nice improvement.
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot