[U-Boot] [Patch 3/3] e1000: remove unnecessary clearing of SWSM.SWSM_SMBI

Bin Meng bmeng.cn at gmail.com
Wed May 20 12:07:07 CEST 2015


On Wed, May 20, 2015 at 1:01 AM, Tim Harvey <tharvey at gateworks.com> wrote:
> remove unnecessary clearing of SWSM.SWSM_SMBI when obtaining the SW
> semaphore. This was introduced in 951860634fdb557bbb58e0f99215391bc0c29779
> while adding i210 support and should be now resolved by releasing the
> semaphore when no longer needed.
>
> Cc: Marcel Ziswiler <marcel at ziswiler.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Aneesh Bansal <aneesh.bansal at freescale.com>
> Cc: Naveen Burmi <NaveenBurmi at freescale.com>
> Cc: Po Liu <po.liu at freescale.com>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: Alison Wang <alison.wang at freescale.com>
> Cc: Reinhard Arlt <reinhard.arlt at esd-electronics.com>
> Cc: Shengzhou Liu  <Shengzhou.Liu at freescale.com>
> Cc: York Sun <yorksun at freescale.com>
> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> ---
>  drivers/net/e1000.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
> index f960024..a78ffc4 100644
> --- a/drivers/net/e1000.c
> +++ b/drivers/net/e1000.c
> @@ -996,10 +996,6 @@ e1000_get_software_semaphore(struct e1000_hw *hw)
>
>         DEBUGFUNC();
>
> -               swsm = E1000_READ_REG(hw, SWSM);
> -               swsm &= ~E1000_SWSM_SMBI;
> -               E1000_WRITE_REG(hw, SWSM, swsm);
> -
>         if (hw->mac_type != e1000_80003es2lan)
>                 return E1000_SUCCESS;
>
> --

Tested on QEMU v2.3.0

Tested-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list