[U-Boot] [PATCH v2 2/6] pci: Do not skip legacy IDE device configuration

[Simon Glass]

On 20 May 2015 at 08:26, Simon Glass <sjg at chromium.org> wrote:
> +Wolfgang
>
> On 18 May 2015 at 19:40, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Simon,
>>
>> Reply this thread to the v2 patch.
>>
>> On Tue, May 19, 2015 at 5:39 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Bin,
>>>
>> On Sat, May 16, 2015 at 9:33 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> The legacy IDE device has a BAR4 (Bus Master Interface BAR) which
>>>> needs to be configured.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Correct a typo in the commit message title
>>>>
>>>>  drivers/pci/pci_auto.c | 14 --------------
>>>>  1 file changed, 14 deletions(-)
>>>
>>> I don't see how this code change relates to your commit message...
>>>
>>
>> The legacy IDE controller reports PI (offset 9 in the configuration
>> space) as 0x80, so the codes here will skip (!(0x80 & 0x05)) its
>> configuration (ie: BAR4 won't be assigned to a valid memory window)
>
> OK I see. It looks like this code has been there since the dawn of
> U-Boot. I added Wolfgang in case we are missing something.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Acked-by: Simon Glass <sjg at chromium.org>