[U-Boot] [PATCH] usb: imx: Allow multiple USB ports to be used at the same time on mx5

[Simon Glass]

Hi,

On 21 May 2015 at 15:13, Matthew Starr <mstarr at hedonline.com> wrote:
> Simon,
>
>> On 21 May 2015 at 15:02, Matthew Starr <mstarr at hedonline.com> wrote:
>> >
>> > CONFIG_MXC_USB_PORT was used to define which USB port was to be
>> > initialized.  If CONFIG_USB_MAX_CONTROLLER_COUNT > 1, then the port
>> > specified by CONFIG_MXC_USB_PORT would be duplicated
>> > CONFIG_USB_MAX_CONTROLLER_COUNT times including duplicating all
>> > devices connected to the ports.  None of the other USB ports would be
>> > available for use.
>> >
>> > The fix is to remove all instances of CONFIG_MXC_USB_PORT from the
>> > imx53 ehci driver since it was only allowing the port specified by
>> > CONFIG_MXC_USB_PORT to be populated.  Then use
>> > CONFIG_USB_MAX_CONTROLLER_COUNT to specifiy which USB ports
>> should be
>> > enabled, starting with port 0.  If port 1 is needed, then set
>> > CONFIG_USB_MAX_CONTROLLER_COUNT to 2 so 2 ports get populated
>> (port 0
>> > and port 1) even though port 0 will not be used.
>> >
>> > Configurations for all boards affected are updated.
>> >
>> > Signed-off-by: Matthew Starr <mstarr at hedonline.com>
>> >
>> > ---
>> >
>> >  drivers/usb/host/ehci-mx5.c    | 8 ++++----
>> >  include/configs/m53evk.h       | 2 +-
>> >  include/configs/mx51_efikamx.h | 1 +
>> >  include/configs/mx51evk.h      | 2 +-
>> >  include/configs/mx53loco.h     | 2 +-
>> >  include/configs/usbarmory.h    | 2 +-
>> >  6 files changed, 9 insertions(+), 8 deletions(-)
>>
>> Perhaps instead this should move to driver model - it supports EHCI.
>> See tegra, exynos, sunxi and sandbox.
>
> Wouldn't that require imx53 support for device trees?  Currently I don't believe that is implemented yet.

Yes, although it's pretty simple. Add CONFIG_OF_CONTROL and
CONFIG_OF_SEPARATE, copy the files in from the kernel and all should
be well.

Regards,
Simon