[U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

Stefan Roese sr at denx.de
Fri May 22 08:39:37 CEST 2015


On 22.05.2015 04:43, Dinh Nguyen wrote:
>
>
> On 5/21/15 6:35 PM, Marek Vasut wrote:
>> On Monday, May 18, 2015 at 09:36:48 PM, dinguyen at opensource.altera.com wrote:
>>> From: Dinh Nguyen <dinguyen at opensource.altera.com>
>>>
>>> This patch adds the DDR calibration portion of the Altera SDRAM driver.
>>>
>>> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
>>
>> Hi,
>>
>> DTTO here. The code is still ugly, but I'm afraid it's not gonna get
>> any better if we keep it out of tree. It'd bet on getting this improved
>> in-tree and under scrutiny from users. What do you think ?
>>
>
> I agree. I really have tried my best to clean it up as best as I can.

Yes, thanks. Really appreciated. I know that especially these kind of 
DDR calibration code tend to be quite complex and "ugly". So I also vote 
for getting this applied now and perhaps improving it in-tree.

For this patch series:

Acked-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan



More information about the U-Boot mailing list