[U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

[Ian Campbell]

On Fri, 2015-05-22 at 09:30 +0200, Hans de Goede wrote:
> Hi,
> 
> On 21-05-15 21:02, Ian Campbell wrote:
> > On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote:
> > [...]
> >> Please create a struct reflecting the register layout and
> >> then initialize a ptr to this struct from the base-address
> >> and get register addresses this way, this is how we deal
> >> with this in pretty much all other sunxi code, see e.g.:
> >
> > This isn't just sunxi, I believe it is u-boot's preferred way to do
> > things generally.
> > [...]
> >> Otherwise this looks like a good start, with the coding
> >> style issues fixed I would not be opposed against merging
> >> this as a first step to growing proper nand support.
> >>
> >> Ian, is that ok with you ?
> >
> > You mean with the coding style fixed but not (necessarily) all the other
> > issues you pointed out (timeouts on loops, structs for register
> > accesses)?
> 
> Sorry, what I meant is are you ok with starting with merging just
> the SPL support without having support for actually reading
> the kernel, etc. as a first step.

Oh yes, that seems completely reasonable.

>  The SPL support would have to
> have all the issues (*) I pointed out fixed before merging.

Agreed.

Ian.