[U-Boot] [PATCH] spl: spl_mmc: Error and count distinction

Tim Harvey tharvey at gateworks.com
Fri May 22 15:41:24 CEST 2015


On Fri, May 22, 2015 at 3:45 AM, Paul Kocialkowski <contact at paulk.fr> wrote:
> This introduces a distinction between return codes that are read bytes counts
> and errors. Read bytes counts are erroneous when null (no data was read) while
> errors are erroneous when non-null.
>
> Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
> ---
>  common/spl/spl_mmc.c | 33 +++++++++++++++++++--------------
>  1 file changed, 19 insertions(+), 14 deletions(-)
>

Paul,

Nice cleanup - it was definately a bit confusing before. I would love
to see function prototypes describing params and return values but its
not like there is much of that in U-Boot elsewhere...

Tested the following configurations:
 - SPL MMC raw sector mode with and without spl_start_uboot()
returning 1 or 0: (CONFIG_SPL_OS_BOOT
!CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION !CONFIG_SPL_FAT_SUPPORT
!CONFIG_SPL_EXT_SUPPORT)

Tested-by: Tim Harvey <tharvey at gateworks.com>

Tim


More information about the U-Boot mailing list