[U-Boot] [PATCH v2] wandboard: Add board revision detection support

[Stefano Babic]

Hi Fabio, Alexander,

On 23/05/2015 18:27, Alexander Holler wrote:
> Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian:
>> On 2015-05-21, Fabio Estevam wrote:
>>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>>
>>> There are two revisions of wandboard: version B1 and C1.
>>>
>>> Add the revision detection support, so that the correct dtb file can
>>> be automatically loaded.
>>>
>>> Based on the patch from Richard Hu <hakahu at gmail.com>.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> Tested on a Wandboard dual (rev c1) and wandboard quad (rev b1).
>>
>> Tested-By: Vagrant Cascadian <vagrant at aikidev.net>
>>
>>> ---
>>> Changes since v1:
>>>
>>> - Fixed commit log to 'automatically loaded'.
>>>
>>>   board/wandboard/wandboard.c | 26 +++++++++++++++++++++++++-
>>>   include/configs/wandboard.h |  8 ++++++--
> 
> Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the
> boot-script in the config to something like "if gpio ..." instead of
> adding something special?
> 
> Assuming the gpio command works on imx, which I haven't tested or looked
> up.

gpio works - this is really a good idea, moving the check into the
script. Fabio, what do you mind ?

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================