[U-Boot] [PATCH v2] wandboard: Add board revision detection support

[Alexander Holler]

Am 24.05.2015 um 20:47 schrieb Fabio Estevam:
> On Sun, May 24, 2015 at 3:03 PM, Alexander Holler <holler at ahsoftware.de> wrote:
> 
>> Hmm, just one comment more.
>>
>> If the gpio command would be enabled, it would even be possible to reset the
>> BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt. So
>> at least WLAN would reliable work even after a reboot or reset, without the
>> need for the rfkill-driver. Also the wandboard-rfkill-driver has more
>> advantages, e.g. the rfkill. ;)
>>
>> For those which don't know it, currently, without the
>> wandboard-rfkill-driver, WLAN works only once after power up, but not after
>> the reboot. Thats because the HW doesn't reset the brcm on reset, so after a
>> reboot or reset uploading the firmware fails (because it is already uploaded
>> due to the missing reset of the module).
> 
> Mainline kernel has proper way of handling the reset of the Wifi chip
> via pwrseq mechanism.
> 
> Please see this patch I did for cuboxi:
> https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt&id=ec5757d85c0fd32274a6052b8a4482d626c01ae5
> 
> So we should really not add such hack in U-boot as mainline kernel has
> the proper solution.

I've not said that I want such a hack in u-boot.

In fact I said that I don't want your hack in u-boot. My suggestion is
to enable the gpio-command in order to make it possible to do stuff like
checking for board revisions without having to modify u-boot at all (the
binary as well as the source).

As long as u-boot doesn't (have to) care about the board-revision, I
don't see the need to add such stuff to a board-file.

But as said, I don't care. But, please, don't suggest that I want to add
a hack.

Alexander Holler