[U-Boot] [PATCH 5/6] x86: qemu: Create i440fx and q35 board configuration and device tree

Simon Glass sjg at chromium.org
Wed May 27 05:13:18 CEST 2015


Hi Bin,

On 25 May 2015 at 08:36, Bin Meng <bmeng.cn at gmail.com> wrote:
> Although the two qemu-x86 targets (i440fx and q35) share a lot in
> common, they still have something that cannot easily handled in one
> place (like different configurations, different properties in the
> device tree). Split to create two dedicated board configuration and
> device tree files and make the i440fx be the default build target.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  arch/x86/dts/Makefile                             |  3 +-
>  arch/x86/dts/qemu-x86_i440fx.dts                  | 34 +++++++++++++++
>  arch/x86/dts/{qemu-x86.dts => qemu-x86_q35.dts}   |  2 +-
>  board/coreboot/coreboot/Kconfig                   |  4 +-
>  board/emulation/qemu-x86/Kconfig                  | 19 +++++++--
>  configs/qemu-x86_defconfig                        |  1 -
>  doc/README.x86                                    | 13 +++++-
>  include/configs/{qemu-x86.h => qemu-x86_i440fx.h} | 20 ++-------
>  include/configs/qemu-x86_q35.h                    | 52 +++++++++++++++++++++++
>  9 files changed, 122 insertions(+), 26 deletions(-)
>  create mode 100644 arch/x86/dts/qemu-x86_i440fx.dts
>  rename arch/x86/dts/{qemu-x86.dts => qemu-x86_q35.dts} (95%)
>  rename include/configs/{qemu-x86.h => qemu-x86_i440fx.h} (78%)
>  create mode 100644 include/configs/qemu-x86_q35.h

Do we need a separate config file? It would be good if all the changes
were in the device tree so that we don't need a separate config. Or at
least that the configs are the same except for the device tree.

Regards,
Simon


More information about the U-Boot mailing list