[U-Boot] [PATCH] imx: missing CONFIG_NET after consolidation patches

[Joe Hershberger]

Hi Heiko,

On Fri, May 29, 2015 at 12:28 AM, Heiko Schocher <hs at denx.de> wrote:
> Hello Joe,
>
>
> Am 28.05.2015 19:53, schrieb Joe Hershberger:
>>
>> Hi Stefano,
>>
>> On Wed, May 27, 2015 at 4:29 AM, Stefano Babic <sbabic at denx.de> wrote:
>>>
>>> commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
>>> "Use env callbacks for net variables" has a side effect
>>> on i.MX6 boards because they do not set CONFIG_NET:
>>> the ip address results not set, but it is stored
>>> in the environment.
>>>
>>> => pri ipaddr
>>> ipaddr=192.168.178.66
>>> => ping 192.168.178.1
>>> *** ERROR: `ipaddr' not set
>>> ping failed; host 192.168.178.1 is not alive
>>>
>>> Setting CONFIG_NET solves this issue.
>>>
>>> Reported-by: Heiko Schoker <hs at denx.de>
>>> Signed-off-by: Stefano Babic <sbabic at denx.de>
>>> ---
>>>   include/configs/mx6_common.h | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
>>> index 233c6d2..3d859cf 100644
>>> --- a/include/configs/mx6_common.h
>>> +++ b/include/configs/mx6_common.h
>>> @@ -105,4 +105,7 @@
>>>   #define CONFIG_FSL_ESDHC
>>>   #define CONFIG_FSL_USDHC
>>>
>>> +/* NET */
>>> +#define CONFIG_NET
>>
>>
>> This config was added to Kconfig here:
>> 60296a8 commands: add more command entries in Kconfig
>> Author: Masahiro Yamada <yamada.m at jp.panasonic.com>
>> Date:   Thu Nov 13 19:29:08 2014 +0900
>>
>> Apparently some of the boards that supported NET previously were not
>> properly added to their defconfigs.
>>
>> In any case, for this board, you should add the NET config to the
>> defconfig, not the header.
>
>
> Hmm.. this seems missing for all imx boards ...
>
> $ grep -lr CONFIG_NET configs | xargs grep MX

It seems that in ed36323f, Masahiro added the CONFIG_NET config to
Kconfig, but most things depended on (and defined) CONFIG_CMD_NET,
which he added to Kconfig in 60296a8. In both cases, none of the
boards had either CONFIG_CMD_NET or CONFIG_NET moved to defconfigs. As
a result most boards are lacking complete networking support except
those that happen to have been touched for other reasons related to
networking (such as the CONFIG_NET_RANDOM_ETHADDR patch).

This is made worse by the fact that I used CONFIG_NET (the one missing
in far more boards) in the fd30563 commit.

I will work up a patch that addresses this and restores networking to
all boards that formerly supported networking.  Expect it tomorrow or
so.

Cheers,
-Joe