[U-Boot] [PATCH v2 2/2] fdt: Rewrite the logic in fdt_fixup_ethernet()

Tom Rini trini at konsulko.com
Tue Nov 3 00:25:16 CET 2015


On Sun, Nov 01, 2015 at 11:58:15PM -0800, Bin Meng wrote:

> Currently in fdt_fixup_ethernet() the MAC address fix up is
> handled in a loop of which the exit condition is to test the
> "eth%daddr" env is not NULL. However this creates unnecessary
> constrains that those "eth%daddr" env variables must be
> sequential even if "ethernet%d" does not start from 0 in the
> "/aliases" node. For example, with "/aliases" node below:
> 
>     aliases {
>         ethernet3 = &enet3;
>         ethernet4 = &enet4;
>     };
> 
> "ethaddr", "eth1addr", "eth2addr" must exist in order to fix
> up ethernet3's MAC address successfully.
> 
> Now we change the loop logic to iterate the properties in the
> "/aliases" node. For each property, test if it is in a format
> of "ethernet%d", then get its MAC address from corresponding
> "eth%daddr" env and fix it up in the dtb.
> 
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> 

Reviewed-by: Tom Rini <trini at konsulko.com>
On OMAP4 Panda (+v4.3 kernel)
Tested-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151102/c33e7107/attachment.sig>


More information about the U-Boot mailing list