[U-Boot] [PATCH v4 16/16] spi: Add SPI NOR protection mechanism

[Fabio Estevam]

On Fri, Oct 30, 2015 at 4:23 PM, Jagan Teki <jteki at openedev.com> wrote:

>> Looks like you are happy with patches 1 to 15 of this series.
>>
>> Could you please apply patches 1 to 15 and then I rework only this last one?
>
> I will pick the entire series once, since 15/16 and 16/16 are same feature set.

Hopefully that will happen some day soon :-)

>
> My questions with 16/16 is
>
> 1. We need to check the idcode as well because if we compile other
> flash vendor with micron, non
> micron flash got initialized with these lock ops' and also assign
> stm_* calls if the idcode is micro.

Done in v5.

>
>> +#if defined(CONFIG_SPI_FLASH_STMICRO)
>> +       flash->lock = spi_flash_cmd_lock_ops;
>> +       flash->unlock = spi_flash_cmd_unlock_ops;
>> +       flash->is_locked = spi_flash_cmd_is_locked_ops;
>> +#endif
>
> 2. Do the 1 for dm as well, probably in probe.

Done in v5.

> 3. What about adding  'sf protect is_locked' since we have code already?

We can add this later if someone thinks it is really needed.