[U-Boot] [PATCH] u-boot/mpc85xx/u-boot*.lds: remove _GLOBAL_OFFSET_TABLE_ definition

[Luo Zhenhua]

Hi Tom, 

> -----Original Message-----
> From: Tom Rini [mailto:trini at konsulko.com]
> Sent: Sunday, October 25, 2015 9:46 PM
> To: Kushwaha Prabhakar-B32579 <prabhakar at freescale.com>
> Cc: u-boot at lists.denx.de; Sun York-R58495 <yorksun at freescale.com>; Luo
> Zhenhua-B19537 <zhenhua.luo at freescale.com>
> Subject: Re: [U-Boot] [PATCH] u-boot/mpc85xx/u-boot*.lds: remove
> _GLOBAL_OFFSET_TABLE_ definition
> 
> On Sun, Oct 25, 2015 at 09:28:50AM +0530, Prabhakar Kushwaha wrote:
> 
> > From: Zhenhua Luo <zhenhua.luo at freescale.com>
> >
> > In binutils-2.25, the _GLOBAL_OFFSET_TABLE_ symbols defined by PROVIDE
> > in u-boot.lds overrides the linker built-in symbols
> > (https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff
> > ;h=b893397a4b1316610f49819344817715e4305de9),
> > so the linker is treating _GLOBAL_OFFSET_TABLE_ as a definition into
> the .reloc section.
> >
> > To align with the change of binutils-2.25, the _GLOBAL_OFFSET_TABLE_
> > symbol should not be defined in sections, and the symbols in linker
> > generated .got section should be
> used(https://sourceware.org/ml/binutils/2008-09/msg00122.html).
> >
> > Fixed the following build errors with binutils-2.25:
> > | powerpc-poky-linux-gnuspe-ld.bfd: _GLOBAL_OFFSET_TABLE_ not defined
> > | in linker created .got
> >
> > Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> 
> What happens when we use older binutils? 
[Luo Zhenhua-B19537] I verified the u-boot build for p4080ds(e500v2) with binutils-2.23.2, the build passed. 

 I'd like some run-time testing too please :)  Thanks!
[Luo Zhenhua-B19537] I did sanity test for the u-boot on p4080ds, it works normally. 

The log files are attached. 


Best Regards,

Zhenhua

> Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot.log
Type: application/octet-stream
Size: 6686 bytes
Desc: u-boot.log
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151103/c66c6374/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-build.log
Type: application/octet-stream
Size: 15547 bytes
Desc: u-boot-build.log
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151103/c66c6374/attachment-0001.obj>