[U-Boot] Riotboard FEC broken

[Stefan Roese]

Hi Catalin, Hi Fabio,

On 05.11.2015 14:04, Fabio Estevam wrote:
> On Thu, Nov 5, 2015 at 9:10 AM, Catalin Crenguta
> <catalin.crenguta at gmail.com> wrote:
>> Hello,
>>
>> I have ran git bisect commit and found out that commit
>> 59370f3fcd135089c402c93720a87c688abe600c breaks FEC on Riotboard.
>> Reverting this change makes it working again.
> 
> I can confirm this. Thanks for running git bisect and reporting it.
> 
> Adding Jörg and Joe on Cc.

I've just checked the Riotboard code for PHY reset handling. And
found this:

static void setup_iomux_enet(void)
{
	imx_iomux_v3_setup_multiple_pads(enet_pads, ARRAY_SIZE(enet_pads));

	/* Reset AR8035 PHY */
	gpio_direction_output(IMX_GPIO_NR(3, 31) , 0);
	mdelay(2);
	gpio_set_value(IMX_GPIO_NR(3, 31), 1);
}

If this PHY needs a delay after deasserting the reset here, then you
should add it in this function (please check the manual for the exact
value). This just used to work before commit
59370f3fcd135089c402c93720a87c688abe600c since you were lucky that
this 15ms delay was added in phy_find_by_mask(). Now its gone and
your PHY is still not out of reset, triggered in setup_iomux_enet().

Thanks,
Stefan