[U-Boot] [PATCH V2 10/13] spl: add support for alternative boot device

Simon Glass sjg at chromium.org
Fri Nov 6 04:15:54 CET 2015


Hi,

On 3 November 2015 at 08:56, Tom Rini <trini at konsulko.com> wrote:
> On Sat, Oct 31, 2015 at 05:39:56PM +0200, Nikita Kiryanov wrote:
>> On Thu, Oct 29, 2015 at 11:19:51AM -0600, Simon Glass wrote:
>> > Hi Nikita,
>> >
>> > On 28 October 2015 at 03:23, Nikita Kiryanov <nikita at compulab.co.il> wrote:
>> > > Introduce spl_boot_list array, which defines a list of boot devices
>> > > that SPL will try before hanging. By default this list will consist
>> > > of only spl_boot_device(), but board_boot_order() can be overridden
>> > > by board code to populate the array with custom values.
>> > >
>> > > Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
>> > > Cc: Igor Grinberg <grinberg at compulab.co.il>
>> > > Cc: Tom Rini <trini at konsulko.com>
>> > > Cc: Simon Glass <sjg at chromium.org>
>> > > ---
>> > > Changes in V2:
>> > >         - No changes.
>> > >
>> > >  common/spl/spl.c | 33 +++++++++++++++++++++++++++++----
>> > >  1 file changed, 29 insertions(+), 4 deletions(-)
>> >
>> > How will we convert this to driver model? I'm worried that this might
>> > create a separate method which will live forever.
>>
>> I don't see how this is related to driver model. This code just fills in
>> an array and iterates over it. Can you elaborate?
>
> Indeed.  With DM we'd just want to make sure that we probe for the
> device before trying to use it, yes?

I'm not sure, hence my question.

I imagine that we might have a 'boot device' as a child of each of
these, but I'm really not sure. Let's worry about it later.

Regards,
Simon


More information about the U-Boot mailing list