[U-Boot] [PATCH 01/10] dm: timer: Fix several nits

Thomas Chou thomas at wytron.com.tw
Fri Nov 6 07:59:16 CET 2015


Hi Bin,

On 2015年11月05日 22:02, Bin Meng wrote:
> This changes 'Timer' to 'timer' at several places.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>   drivers/timer/Kconfig        | 10 +++++-----
>   drivers/timer/timer-uclass.c |  4 ++--
>   include/timer.h              | 11 ++++++-----
>   3 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig
> index 97c4128..895de38 100644
> --- a/drivers/timer/Kconfig
> +++ b/drivers/timer/Kconfig
> @@ -1,19 +1,19 @@
>   menu "Timer Support"
>
>   config TIMER
> -	bool "Enable Driver Model for Timer drivers"
> +	bool "Enable driver model for timer drivers"
>   	depends on DM
>   	help
> -	  Enable driver model for Timer access. It uses the same API as
> -	  lib/time.c. But now implemented by the uclass. The first timer
> +	  Enable driver model for timer access. It uses the same API as
> +	  lib/time.c, but now implemented by the uclass. The first timer
>   	  will be used. The timer is usually a 32 bits free-running up
>   	  counter. There may be no real tick, and no timer interrupt.
>
>   config ALTERA_TIMER
> -	bool "Altera Timer support"
> +	bool "Altera timer support"
>   	depends on TIMER
>   	help
> -	  Select this to enable an timer for Altera devices. Please find
> +	  Select this to enable a timer for Altera devices. Please find
>   	  details on the "Embedded Peripherals IP User Guide" of Altera.
>
>   endmenu
> diff --git a/drivers/timer/timer-uclass.c b/drivers/timer/timer-uclass.c
> index 12aee5b..82c6897 100644
> --- a/drivers/timer/timer-uclass.c
> +++ b/drivers/timer/timer-uclass.c
> @@ -10,10 +10,10 @@
>   #include <timer.h>
>
>   /*
> - * Implement a Timer uclass to work with lib/time.c. The timer is usually
> + * Implement a timer uclass to work with lib/time.c. The timer is usually
>    * a 32 bits free-running up counter. The get_rate() method is used to get
>    * the input clock frequency of the timer. The get_count() method is used
> - * get the current 32 bits count value. If the hardware is counting down,
> + * to get the current 32 bits count value. If the hardware is counting down,
>    * the value should be inversed inside the method. There may be no real
>    * tick, and no timer interrupt.
>    */
> diff --git a/include/timer.h b/include/timer.h
> index cdf385d..ed5c685 100644
> --- a/include/timer.h
> +++ b/include/timer.h
> @@ -10,30 +10,31 @@
>   /*
>    * Get the current timer count
>    *
> - * @dev: The Timer device
> + * @dev: The timer device
>    * @count: pointer that returns the current timer count
>    * @return: 0 if OK, -ve on error
>    */
>   int timer_get_count(struct udevice *dev, unsigned long *count);
> +
>   /*
>    * Get the timer input clock frequency
>    *
> - * @dev: The Timer device
> + * @dev: The timer device
>    * @return: the timer input clock frequency
>    */
>   unsigned long timer_get_rate(struct udevice *dev);
>
>   /*
> - * struct timer_ops - Driver model Timer operations
> + * struct timer_ops - Driver model timer operations
>    *
> - * The uclass interface is implemented by all Timer devices which use
> + * The uclass interface is implemented by all timer devices which use
>    * driver model.
>    */
>   struct timer_ops {
>   	/*
>   	 * Get the current timer count
>   	 *
> -	 * @dev: The Timer device
> +	 * @dev: The timer device
>   	 * @count: pointer that returns the current timer count
>   	 * @return: 0 if OK, -ve on error
>   	 */
>

Thanks. Might need rebase after nios2 timer cleaned up and sandbox timer 
added. Otherwise,

Ack-by: Thomas Chou <thomas at wytron.com.tw>


More information about the U-Boot mailing list