[U-Boot] [PATCH v7 0/5] Add support for Thumb-1 builds

Albert ARIBAUD albert.u.boot at aribaud.net
Tue Nov 10 15:02:42 CET 2015


Hello Albert,

On Fri, 23 Oct 2015 18:06:38 +0200, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:
> This series implements essential changes for thumb-1 support and
> activates thumb-1 build for openrd and tricorder as a proof of
> concept as well as a fix to bring the image sizes of openrd and
> tricorder targets back under an acceptable limit.
> 
> For other targets, some additional files might need to be forced to
> ARM building, notably architecture-specific instances of lowlevel_init.S
> or of cpu.c. This should be handled on a case-by-case basis.
> 
> This series has two unfixed checkpatch diagnostics:
> 
> warning: arch/arm/mach-kirkwood/Kconfig,7:
> please write a paragraph that describes the config symbol fully
> 
> (no option in this Kconfig has help info)
> 
> check: board/Marvell/openrd/openrd.c,42: Avoid CamelCase: <MPP6_SYSRST_OUTn>
> 
> (this is actually not an OpenRD problem and will be fixed
> in another patch)
> 
> IMPORTANT NOTE:
> 
> The whole set has been build-tested across all ARM targets
> and no build regression was detected -- actually, the series
> does fix the x600 board which otherwise fails assembling an
> mcr instruction.
> 
> Patch 1 has been confirmed to be binary-invariant.
> 
> Patch 2 has been build- and run-tested on ED Mini V2 (switched
> temporarily to Thumb build) and confirmed to be binary-invariant
> for non-thumb target Wireless Space.
> 
> Patches 3 through 6 have been build-tested BUT HAVE NOT BEEN
> RUN-TESTED so far.
> 
> I will test on OpenRD (client) before the end of the merge
> window, but:
> 
> *********************************************************
> Open-RD and Tricorder owners, PLEASE run-test this series
> and report on the mailing list whether the target works.
> *********************************************************

Tests on OpenRD-Client uncovered an issue with commit 5ba534d2 (which
introduced board_init_f_mem for crt0.S) and gcc 5.2.1. Because of
this, the series was not applied so far, and a fix to 5ba534d2 was
posted, on which I intended to have the series depend (and I have
verified that with the fix, the series boots fine on OpenRD-Client).

However, there is already at least one board broken by 5ba534d2
(cgtqmx6eval, see <http://patchwork.ozlabs.org/patch/542266/>) for
which a revert was posted.

Since there is already breakage in u-boot/master, and since there will
be a fix to 5ba534d2 eventually, and since this Thumb-1 series has
lingered for long enough:

Applied to u-boot-arm/master.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list