[U-Boot] [PATCH v3 00/12] dm: input: Move keyboard drivers to driver model

[Simon Glass]

Hi Bin,

On 12 November 2015 at 06:33, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Thu, Nov 12, 2015 at 11:56 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Simon,
>>
>> On Thu, Nov 12, 2015 at 5:56 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Bin,
>>>
>>> On 11 November 2015 at 10:05, Simon Glass <sjg at chromium.org> wrote:
>>>> This series adds a new uclass for keyboards and converts some drivers
>>>> over to use it.
>>>>
>>>> This series includes some work to remove code duplication in the keyboard
>>>> drivers by updating them to use the input library (input.c). This unifies
>>>> the keycode decoding logic in one place. In order to do this some
>>>> enhancements are needed to the input library and these are also included.
>>>>
>>>> The cros_ec and tegra_kbc drivers are converted to use driver model.
>>>>
>>>> The i8042 driver is converted also, after various tidy-ups. The driver has
>>>> some strange interactions with the cfb_console driver. This is removed in
>>>> this series which is possible because the only user is x86. Some i8042
>>>> features have been dropped (the only deliberate one is the flashing cursor
>>>> which does not seem to be used by any board).
>>>>
>>>> Also the i8042 driver currently has its own keycode-decoding logic. This
>>>> series removes it in favour of the input library. Therefore testing of this
>>>> new driver would be appreciated. So far I have only been able to test on
>>>> link, which does not have a full keyboard. Also, while German keyboard
>>>> support is implemented, I am unable to test that either.
>>>>
>>>> These changes can be considered the first step towards moving stdio to
>>>> driver model. For that to be useful we need to convert LCD and video also.
>>>>
>>>> Note: This series is missing the code to call the update_leds() method when
>>>> the LEDs change. This needs to be added to keyboard_tstc() and
>>>> keyboard_getc(). If someone is able to test this I can send a patch for that
>>>> also.
>>>>
>>>> This series is available at u-boot-dm branch input-working.
>>>
>>> Can you please try testing this for your crash when pressing 'caps
>>> lock'? I'm not sure what is going on there and I don't have hardware
>>> to test with.
>>
>> I've tested the v3 patch. Looks the behavior is the same as v2. Note
>> the crash when pressing 'caps lock' only happens in v1. Starting from
>> v2, pressing 'caps lock' does not light the LED, and the characters
>> typed is still lower case. This is the same as the 'num lock' as I
>> reported before.
>>
>
> I've spent some time to debug this today, and have fixed all of these
> issues I reported so far. Please check my patch series @
> http://patchwork.ozlabs.org/patch/543339/

That's great! Thanks for all the testing and patches. It's really hard
to refactor code without hardware to test - lucky that you have it.

Regards,
Simon