[U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment
Thomas Chou
thomas at wytron.com.tw
Fri Nov 13 09:20:39 CET 2015
Hi Albert,
On 2015年11月13日 14:41, Albert ARIBAUD wrote:
> Hello Thomas,
>
> On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou <thomas at wytron.com.tw>
> wrote:
>> Hi Albert,
>
>> - /* Update stack- and frame-pointers */
>> - mov sp, r2
>> - mov fp, sp
>
> Just a sec here on second thought.
>
> I understand the 'mov sp, r2' must be removed as it is replaced by a
> 'sub sp, sp, r2' a few lines earlier.
>
> But doesn't the 'mov fp, sp' need to remain? Without it, fp is not set
> any more, is it?
>
Yes, the 'mov fp, sp' need to remain. I forgot to add them.
Best regards,
Thomas
More information about the U-Boot
mailing list