[U-Boot] [PATCH v7 21/21] sf: Add SPI NOR protection mechanism

[Bin Meng]

On Thu, Nov 12, 2015 at 12:25 AM, Jagan Teki <jteki at openedev.com> wrote:
> On 11 November 2015 at 15:13, Fabio Estevam <festevam at gmail.com> wrote:
>> On Wed, Nov 11, 2015 at 12:56 AM, Simon Glass <sjg at chromium.org> wrote:
>>
>>> It crashes reading the environment:
>>>
>>> U-Boot 2015.10-00544-gcad0499 (Nov 10 2015 - 17:06:00 -0700)
>>>
>>> CPU:   Intel(R) Core(TM) i5-3427U CPU @ 1.80GHz
>>> DRAM:  2.7 GiB
>>> SF: Detected W25Q64CV with page size 256 Bytes, erase size 4 KiB, total 8 MiB
>>> *** Warning - bad CRC, using default environment
>>>
>>> Video: 1280x1024x16
>>> Model: Google Link
>>> SF: Detected W25Q64CV with page size 256 Bytes, erase size 4 KiB, total 8 MiB
>>> Invalid Opcode (Undefined Opcode)
>>> EIP: 0010:[<00000058>] EFLAGS: 00010283
>>> Original EIP :[<52fbb058>]
>>
>> In this patch we only assign the lock ops if the flash is of ST Micro
>> type, so not sure why it affects Winbound flash as well.
>>
>> Jagan, would you have some ideas, please?
>
> Issue still there? because we added these lock ops only for ST Micro flash's.
>
> thanks!
> --

It now breaks SPI flash on Intel Crown Bay too ..

=> saveenv
Saving Environment to SPI Flash...
SF: Detected SST25VF016B with page size 256 Bytes, erase size 4 KiB, total 2 MiB
Erasing SPI flash...Invalid Opcode (Undefined Opcode)
EIP: 0010:[<00000006>] EFLAGS: 00010213
Original EIP :[<c0b9e006>]
EAX: 3f164f30 EBX: 00000000 ECX: 00001000 EDX: 00000000
ESI: 00001000 EDI: 00001000 EBP: 3f164f30 ESP: 3f15b77c
 DS: 0018 ES: 0018 FS: 0020 GS: 0018 SS: 0018
CR0: 00000033 CR2: 00000000 CR3: 00000000 CR4: 00000600
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
Stack:
    0x3f15b7bc : 0x3f387b0e
    0x3f15b7b8 : 0x3f3c6108
    0x3f15b7b4 : 0x00000000
    0x3f15b7b0 : 0x3f15b7e0
    0x3f15b7ac : 0x3f3ab6cc
    0x3f15b7a8 : 0x00001000
    0x3f15b7a4 : 0x3f1610b8
    0x3f15b7a0 : 0x3f3af400
    0x3f15b79c : 0x3f388036
    0x3f15b798 : 0x00000000
    0x3f15b794 : 0x00000ffc
    0x3f15b790 : 0x3f15b7bc
    0x3f15b78c : 0x3f38e9ec
    0x3f15b788 : 0x0000002e
    0x3f15b784 : 0x3f1610b8
    0x3f15b780 : 0x0000002e
--->0x3f15b77c : 0x3f38838b
    0x3f15b778 : 0x00010213
    0x3f15b774 : 0x00000010
    0x3f15b770 : 0x00000006
### ERROR ### Please RESET the board ###

Regards,
Bin