[U-Boot] [PATCH] sf: Fix NULL pointer exception for flashes without lock methods

Jagan Teki jteki at openedev.com
Fri Nov 13 14:31:40 CET 2015


On Nov 13, 2015 6:37 PM, "Bin Meng" <bmeng.cn at gmail.com> wrote:
>
> Hi Tom,
>
> On Fri, Nov 13, 2015 at 6:49 PM, Fabio Estevam <festevam at gmail.com> wrote:
> > On Fri, Nov 13, 2015 at 8:46 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
> >> commit c3c016c "sf: Add SPI NOR protection mechanism" introduced
> >> flash_lock()/flash_unlock()/flash_is_locked() methods for SPI flash,
> >> but not every flash driver supplies these. We should test these
> >> methods against NULL before actually calling them.
> >>
> >> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> >
> > Thanks for the fix.
> >
> > Reviewed-by: Fabio Estevam <fabio.estevam at freescale.com>
>
> Could you please apply this directly as this fix booting crash at
> least on Chromebook Link?

Reviewed-by: Jagan Teki <jteki at openedev.com>


More information about the U-Boot mailing list