[U-Boot] [PATCH] rockchip: Turn on CONFIG_DEBUG_LL for firefly

[Ariel D'Alessandro]

Eze,

El 12/11/15 a las 19:11, Ezequiel Garcia escribió:
> On 12 November 2015 at 18:42, Ariel D'Alessandro
> <ariel at vanguardiasur.com.ar> wrote:
>> CONFIG_DEBUG_UART is enabled in defconfig, but there's no Low-level
>> debugging functions implemented, so build fails because of undefined
>> references to `printch' in common/console.c.
>> In order to fix this, enable CONFIG_DEBUG_LL.
>>
> 
> I think you are fixing this the wrong way. This patch
> solves the problem as well, and I think it's the right way:
> 
> [patch format is probably wasted]
> @@ -34,6 +34,7 @@ CONFIG_REGULATOR_ACT8846=y
>  CONFIG_RAM=y
>  CONFIG_SPL_RAM=y
>  CONFIG_DEBUG_UART=y
> +CONFIG_DEBUG_UART_NS16550=y
>  CONFIG_DEBUG_UART_BASE=0xff690000
>  CONFIG_DEBUG_UART_CLOCK=24000000
>  CONFIG_DEBUG_UART_SHIFT=2
> 
> Without this fix, Altera JTAG UART is selected instead of NS16550.

You're right. No UART driver is specified in defconfig, thus
DEBUG_UART_ALTERA_JTAGUART is incorrectly selected by default.
In fact, firefly-rk3288_defconfig got broken after the following commit
was applied:

    commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb
    Author: Thomas Chou <thomas at wytron.com.tw>

        nios2: convert altera_jtag_uart to driver model

> I expect other defconfigs (e.g. chromebook_jerry_defconfig) to suffer
> from this as well.

Yes, chromebook_jerry_defconfig has exactly the same problem.

> 
> That said, I still haven't looked at the differences between
> DEBUG_LL and DEBUG_UART.
> 

-- 
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar