[U-Boot] [PATCH V2 08/12] board: mpl: Move common headers to board-common directory

[Tom Rini]

On Fri, Nov 13, 2015 at 09:19:32AM +0100, David Müller (ELSOFT AG) wrote:
> Hello
> 
> Nishanth Menon wrote:
> > Header files can be located in a generic location without needing to
> > reference them with ../common/
> > 
> > board/mpl/common/{ => include/board-common}/common_util.h (100%) 
> > rename board/mpl/common/{ => include/board-common}/isa.h (100%)
> 
> Correct me if I'm missing something here but I don't see the actual gain
> of doing this. "board/mpl/common" contains MPL specific things which
> should be kept as locally to the MPL boards directory as possible.

The gain here is to make it easy and consistent in how we access and
store things which are common to a vendor, but say spread over SoCs (and
even architectures).  We have a few ad-hoc methods today and Nishanth is
consolidating things after another thread we just had.

> For example how is a potential other "isa.h" file from another vendor
> and/or board handled? By using a <VENDOR><BOARD> prefix/suffix?

If we run into two vendors having the same header file, and it being
needed in common code (rather than vendor-common code) then we've put
information in the wrong place.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151113/c1788e47/attachment.sig>