[U-Boot] [PATCH V2 07/12] board: LaCie: Move common headers to board-common directory

Masahiro Yamada yamada.masahiro at socionext.com
Sun Nov 15 00:56:02 CET 2015


2015-11-13 14:43 GMT+09:00 Nishanth Menon <nm at ti.com>:
> Header files can be located in a generic location without
> needing to reference them with ../common/
>
> Generated with the following script
>
>  #!/bin/bash
> vendor=board/LaCie
> common=$vendor/common
>
> cfiles=`git grep "../common" $vendor|grep "#include"|cut -d '"' -f2|sort -u|grep c$`
> headers=`git grep "../common" $vendor|grep "#include"|cut -d '"' -f2|sort -u|grep h$`
>
> mkdir -p $common/include/board-common
> set -x
> for header in $headers
> do
>         echo "processing $header in $common"
>         hbase=`basename $header`
>         git mv $common/$hbase $common/include/board-common
>         sed -i -e "s/\"..\/common\/$hbase\"/<board-common\/$hbase>/g" $vendor/*/*.[chS]
>         sed -i -e "s/\"$hbase\"/<board-common\/$hbase>/g" $vendor/common/*.[chS]
> done
>
> Cc: Simon Guinot <simon.guinot at sequanux.org>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>
> Signed-off-by: Nishanth Menon <nm at ti.com>
> ---


As far as I understood from 02 to 12,
the effect of this series is:

either
  replace "../common/foo.h" with <board-common/foo.h>
or
  replace "bar.h" with <board-common/bar.h>


Vendor common headers are referenced within their own directory.
#include "..." is better than #include <...> in such cases.

I still do not understand what problem this series wants to solve.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list