[U-Boot] [PATCH 17/17] eeprom: Clean up checkpatch issues

Heiko Schocher hs at denx.de
Mon Nov 16 12:32:47 CET 2015


Hello Marek,

Am 10.11.2015 um 20:53 schrieb Marek Vasut:
> Cosmetic fixes to the file, make it checkpatch clean.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Heiko Schocher <hs at denx.de>
> ---
>   common/cmd_eeprom.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
>
> diff --git a/common/cmd_eeprom.c b/common/cmd_eeprom.c
> index 13c946e..376c57d 100644
> --- a/common/cmd_eeprom.c
> +++ b/common/cmd_eeprom.c
> @@ -49,8 +49,8 @@
>    */
>   #if !defined(CONFIG_SPI) || defined(CONFIG_ENV_EEPROM_IS_ON_I2C)
>   #if !defined(CONFIG_SYS_I2C_EEPROM_ADDR_LEN) || \
> -    (CONFIG_SYS_I2C_EEPROM_ADDR_LEN < 1) || \
> -    (CONFIG_SYS_I2C_EEPROM_ADDR_LEN > 2)
> +	(CONFIG_SYS_I2C_EEPROM_ADDR_LEN < 1) || \
> +	(CONFIG_SYS_I2C_EEPROM_ADDR_LEN > 2)
>   #error CONFIG_SYS_I2C_EEPROM_ADDR_LEN must be 1 or 2
>   #endif
>   #endif
> @@ -183,7 +183,8 @@ int eeprom_read(unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cnt)
>   	return eeprom_rw(dev_addr, offset, buffer, cnt, 1);
>   }
>
> -int eeprom_write(unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cnt)
> +int eeprom_write(unsigned dev_addr, unsigned offset,
> +		 uchar *buffer, unsigned cnt)
>   {
>   	int ret;
>
> @@ -234,19 +235,19 @@ static int do_eeprom(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>
>   	eeprom_init(bus_addr);
>
> -	if (strcmp (argv[1], "read") == 0) {
> +	if (strcmp(argv[1], "read") == 0) {
>   		printf(fmt, dev_addr, argv[1], addr, off, cnt);
>
> -		rcode = eeprom_read(dev_addr, off, (uchar *) addr, cnt);
> +		rcode = eeprom_read(dev_addr, off, (uchar *)addr, cnt);
>
> -		puts ("done\n");
> +		puts("done\n");
>   		return rcode;
> -	} else if (strcmp (argv[1], "write") == 0) {
> +	} else if (strcmp(argv[1], "write") == 0) {
>   		printf(fmt, dev_addr, argv[1], addr, off, cnt);
>
> -		rcode = eeprom_write(dev_addr, off, (uchar *) addr, cnt);
> +		rcode = eeprom_write(dev_addr, off, (uchar *)addr, cnt);
>
> -		puts ("done\n");
> +		puts("done\n");
>   		return rcode;
>   	}
>
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list