[U-Boot] [PATCH 10/17] powerpc/km8321: set the DDRCDR impedance settings back to half strength

Tom Rini trini at konsulko.com
Mon Nov 16 14:34:45 CET 2015


On Mon, Nov 16, 2015 at 01:26:53PM +0100, Holger Brunck wrote:
> Hi Valentin,
> 
> On 13/11/15 15:59, Valentin Longchamp wrote:
> > The impedance settings have been changed with commit
> > 2ea8ae99595ca11dd228726e854ebc6268208601 (whose goal was to set
> > the internal voltage level to the DDR2 value - and not DDR1).
> > 
> 
> you are referencing the previous patch 09/17 here, shouldn't these two then not
> be squashed?

It's bad form to reference commit IDs of previous parts of a series as
they will not match what happens when commited to the tree so please say
the commit subject instead.  And as Holger suggests, if this reference
patch 9/17 here, just squash the two together and v2 just that patch
please (assuming no further feedback on the series), thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151116/23beeb28/attachment.sig>


More information about the U-Boot mailing list